Fix #418, reorganize header files and restructure messages #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL-coding-standard found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
jphickey
force-pushed
the
fix-418-header-reorg
branch
3 times, most recently
from
adff380 to
5b6fc9a
Compare
|
CCB 30 November 2023: Approved pending rebase. |
dzbaker
added
CCB:Provisionally-Approved
and removed
CCB:Ready
Move the header files to a "config" directory as documented in the CFE guidelines, which allows easier override. Organize the content to adhere to the patterns. Specifically - adds a dedicated structure type for each cmd, and also puts the payload into a separate sub-structure. Command handlers and tests updated accordingly (many of which were simplified).
jphickey
force-pushed
the
fix-418-header-reorg
branch
from
5b6fc9a to
323ff05
Compare
|
@dzbaker -- this is now rebased, should be OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Move the header files to a "config" directory as documented in the CFE guidelines, which allows easier override.
Organize the content to adhere to the patterns.
Specifically - adds a dedicated structure type for each cmd, and also puts the payload into a separate sub-structure.
Command handlers and tests updated accordingly (many of which were simplified).
Fixes #418
Testing performed
Build and run all tests
Execute local file transfer using 2 instances of CFS + CFDP app
Expected behavior changes
Nothing on the external interface changes
System(s) tested on
Debian
Additional context
First step of making CF adhere to current patterns
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.