Fix #1708, Align padding explicitly in cfe_tbl_msg.h #2278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_TBL_HousekeepingTlm_Payload_t
#1708CFE_TBL_HousekeepingTlm_Payload_t
as noted in the issue has been made explicit, and my testing showed 2-byte implicit padding on the end ofCFE_TBL_TblRegPacket_Payload_t
as well, which has also been rectified and made explicit.Note: If this is merged, it will require updates to
cfe-tbl-hk-tlm.txt
in the Ground System tool to ensure clean and correct interpretation of the data members.Testing performed
GitHub CI actions all passing successfully.
Local testing confirms all cFS bundle tests passing and coverage unaffected.
Expected behavior changes
Compilers trying to align to 32-bits will not longer add implicit padding in these 2 locations.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt