Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3919: Remove invalid group permissions #1318

Merged
merged 2 commits into from
Nov 8, 2024
Merged

MMT-3919: Remove invalid group permissions #1318

merged 2 commits into from
Nov 8, 2024

Conversation

htranho
Copy link
Contributor

@htranho htranho commented Nov 6, 2024

Overview

What is the feature?

MMT displays invalid group permissions, which show up with empty group name in the UI.

What is the Solution?

Remove invalid group permissions so they don't show up.

What areas of the application does this impact?

Single permission view.

Testing

See test session

Attachments

See ticket.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (d7ea081) to head (458f90c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1318   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         366      366           
  Lines        5743     5743           
  Branches     1205     1195   -10     
=======================================
  Hits         5610     5610           
  Misses        132      132           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@htranho htranho changed the title MMT-3923: Remove invalid group permissions MMT-3919: Remove invalid group permissions Nov 8, 2024
@htranho htranho merged commit 236f2cb into main Nov 8, 2024
5 of 7 checks passed
@htranho htranho deleted the MMT-3919 branch November 8, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants