Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3903: Update MMT to the new UMM-C schema #1321

Merged
merged 7 commits into from
Nov 15, 2024
Merged

MMT-3903: Update MMT to the new UMM-C schema #1321

merged 7 commits into from
Nov 15, 2024

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Nov 14, 2024

Overview

What is the feature?

Update fMMT to new UMM-C schema:
UMM-C schema added PREPRINT, INREVIEW, and SUPERSEDED to CollectionProgress
UMM-C schema removed NOT APPLICABLE in CollectionProgress
UMM-C schema added IsPreviousVersionOf and IsNewVersionOf to AssociatedDOIs/Type

What is the Solution?

updated ummCSchema and config files

What areas of the application does this impact?

ummCSchema.js and static.config

Testing

Reproduction steps

  • **Environment for testing: SIT
  • **Collection to test with: New Draft
  1. Create a new draft in in SIT and give Collection Progress Preprint, InReview, and Superseded.
  2. In that same draft give AssociatedDOIs/Type IsPReviousVersionOf and IsNewVersionOf
  3. Try publishing with all those choices

Attachments

N/A

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (9316f6f) to head (78ae0af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1321   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         366      366           
  Lines        5743     5743           
  Branches     1194     1205   +11     
=======================================
  Hits         5610     5610           
  Misses        132      132           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandyparson mandyparson merged commit c84acf9 into main Nov 15, 2024
5 of 7 checks passed
@mandyparson mandyparson deleted the MMT-3903 branch November 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants