Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nasa/nos3#285] Attempted to implemented suggestions from sdunlap-afit #324

Merged
merged 2 commits into from
Jul 2, 2024
Merged

[nasa/nos3#285] Attempted to implemented suggestions from sdunlap-afit #324

merged 2 commits into from
Jul 2, 2024

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Jun 27, 2024 •
edited
Loading

Attempted to implemented suggestions from sdunlap-afit and resolved issue with running minimal-config.

Requires the following pull request(s) completed and submodules updated prior to merge:

@jlucas9 jlucas9 added the Bug Something isn't working label Jun 27, 2024
@jlucas9 jlucas9 self-assigned this Jun 27, 2024
kevincbruce
kevincbruce approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, as long as the root commit is good, and the gui works if we change the config back.

szemerick
szemerick approved these changes Jul 2, 2024
View reviewed changes
Copy link

@szemerick szemerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the low-level time driver code. It looks good, although this is tricky code. I don't see any issues.

@jlucas9 jlucas9 merged commit 874e016 into dev Jul 2, 2024
4 checks passed
@jlucas9 jlucas9 deleted the nos3#285 branch July 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szemerick szemerick szemerick approved these changes

@kevincbruce kevincbruce kevincbruce approved these changes

@rjbrown2 rjbrown2 rjbrown2 approved these changes

@msuder msuder Awaiting requested review from msuder

@dccutrig dccutrig Awaiting requested review from dccutrig

@zlynch2 zlynch2 Awaiting requested review from zlynch2

Assignees

@jlucas9 jlucas9

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlucas9 @szemerick @kevincbruce @rjbrown2