Split battery EOD

[teubert]

Split battery EOD into 2 different events (lowvoltage and discharge), keeping EOD for backwards compatibility.

Open questions:

• What should V_0 be?
• What is the minimum charge?

[github-actions]

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

• Reviewer should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
• Ensure that each PR adding a new feature should include a test verifying that feature.
• All tests must be passing.
• All errors from static analysis must be resolved.
• Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
• Review the software benchmarking results (if there is a change) - will be added as comment on PR
• Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
• All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

[github-actions]

Benchmarking Results
From:

Test	Time (s)
import main	0.6160796
import thrown object	0.44443940000000015
model initialization	0.0002772000000001995
set noise	2.700000000022129e-06
simulate	0.0004790000000001182
simulate with saving	0.0013855000000000395
simulate with saving, dt	0.003138499999999933
simulate with printing results, dt	0.004154100000000049
Plot results	0.022031599999999818
Metrics	0.00037650000000000183
Surrogate Model Generation	2.0972323
surrogate sim	0.002321699999999982
surrogate sim, dt	0.0040759999999999685
To:
Test	Time (s)
---	---
import main	0.9056002000000001
import thrown object	0.5113213000000001
model initialization	0.00024250000000014538
set noise	2.9999999999752447e-06
simulate	0.0005767000000000966
simulate with saving	0.0013689999999999536
simulate with saving, dt	0.0030239000000000793
simulate with printing results, dt	0.004225300000000098
Plot results	0.024585300000000032
Metrics	0.0005683000000000771
Surrogate Model Generation	2.2020676
surrogate sim	0.002101100000000411
surrogate sim, dt	0.0038171000000000177

[github-actions]

Benchmarking Results [Update]
From:

Test	Time (s)
import main	0.6304951
import thrown object	0.4454983000000001
model initialization	0.0002603000000001021
set noise	2.899999999916858e-06
simulate	0.00045700000000015173
simulate with saving	0.0011502000000001011
simulate with saving, dt	0.0026345999999999314
simulate with printing results, dt	0.003267799999999932
Plot results	0.021274400000000027
Metrics	0.0003849999999998577
Surrogate Model Generation	2.0022843999999997
surrogate sim	0.001638199999999923
surrogate sim, dt	0.003328900000000079

To:

Test	Time (s)
import main	0.9683271
import thrown object	0.56081
model initialization	0.0002677999999998182
set noise	3.0000000001972893e-06
simulate	0.00046119999999993944
simulate with saving	0.001097899999999985
simulate with saving, dt	0.002686699999999931
simulate with printing results, dt	0.003190199999999921
Plot results	0.019390100000000077
Metrics	0.0003827000000000691
Surrogate Model Generation	2.2419605000000002
surrogate sim	0.0016294999999999504
surrogate sim, dt	0.003368599999999944

[github-actions]

Benchmarking Results [Update]
From:

Test	Time (s)
import main	0.6694861
import thrown object	0.5008237999999999
model initialization	0.000349600000000061
set noise	4.499999999962867e-06
simulate	0.0005581999999999532
simulate with saving	0.001458700000000146
simulate with saving, dt	0.00341289999999983
simulate with printing results, dt	0.0046744000000000785
Plot results	0.024789000000000172
Metrics	0.00043799999999993844
Surrogate Model Generation	2.2855365
surrogate sim	0.0019273000000001872
surrogate sim, dt	0.004027600000000131

To:

Test	Time (s)
import main	0.9936370999999999
import thrown object	0.5431689
model initialization	0.0003755000000000841
set noise	4.500000000184912e-06
simulate	0.0005756999999999568
simulate with saving	0.0014836999999998657
simulate with saving, dt	0.0033708999999999545
simulate with printing results, dt	0.004700300000000102
Plot results	0.025630400000000053
Metrics	0.000520800000000099
Surrogate Model Generation	2.4379342000000004
surrogate sim	0.001957899999999846
surrogate sim, dt	0.003794300000000028

[github-actions]

Benchmarking Results [Update]
From:

Test	Time (s)
import main	0.6168973
import thrown object	0.45541560000000003
model initialization	0.00029759999999989795
set noise	3.7999999999982492e-06
simulate	0.00043890000000001983
simulate with saving	0.001210199999999828
simulate with saving, dt	0.0025589000000001416
simulate with printing results, dt	0.0032611000000000168
Plot results	0.01980420000000005
Metrics	0.0003906000000000187
Surrogate Model Generation	1.9350190999999999
surrogate sim	0.001649100000000292
surrogate sim, dt	0.003265900000000155

To:

Test	Time (s)
import main	0.8909691
import thrown object	0.5148288000000001
model initialization	0.0003185999999999467
set noise	3.6000000001035204e-06
simulate	0.0004629999999998802
simulate with saving	0.0010950999999999045
simulate with saving, dt	0.0026625999999998484
simulate with printing results, dt	0.0031830999999999943
Plot results	0.020323199999999986
Metrics	0.0003838000000000452
Surrogate Model Generation	2.0775076
surrogate sim	0.0016493000000004088
surrogate sim, dt	0.003267800000000154