Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Katy Jarvis Griffith <55932920+kjjarvis@users.noreply.github.com>
  • Loading branch information
teubert and kjjarvis committed Sep 15, 2023
1 parent b411f9b commit 0ac2d54
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions examples/01_Simulation.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"The next configurable parameter in simulation is the step size, or `dt`. This is the size of the step taken from one step to the next when simulating. Smaller step sizes will usually more accurately simulate state evolution, but at a computational cost. Conversely, some models can become unstable at large step sizes. Chosing the correct step size is important to the success of a simulation or prediction.\n",
"The next configurable parameter in simulation is the step size, or `dt`. This is the size of the step taken from one step to the next when simulating. Smaller step sizes will usually more accurately simulate state evolution, but at a computational cost. Conversely, some models can become unstable at large step sizes. Choosing the correct step size is important to the success of a simulation or prediction.\n",
"\n",
"In this section we will introduce the concept of setting simulation step size (`dt`) and discuss some considerations when selecting step sizes.\n",
"\n",
Expand Down Expand Up @@ -982,7 +982,7 @@
"source": [
"Note that the parabola above is jagged. Also note that the estimated time of impact is around 10 seconds and the maximum height is a little over 120 meters. \n",
"\n",
"Now lets run the simulation again with a smaller step size."
"Now let's run the simulation again with a smaller step size."
]
},
{
Expand Down Expand Up @@ -1100,7 +1100,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"There are times when an advanced user would like more flexibility in selecting step sizes. This can be used to adjust step size dynamically close to events or times of interest. In some models, there are complex behaviors during certain parts of the life of the system that require more precise simulation. For example, the knee point in the voltage profile for a discharged batter. This can be done by providing a function (t, x)->dt instead of a scalar `dt`. \n",
"There are times when an advanced user would like more flexibility in selecting step sizes. This can be used to adjust step size dynamically close to events or times of interest. In some models, there are complex behaviors during certain parts of the life of the system that require more precise simulation. For example, the knee point in the voltage profile for a discharged battery. This can be done by providing a function (t, x)->dt instead of a scalar `dt`. \n",
"\n",
"For example, if a user wanted to reduce the step size closer to impact, they could do so like this:"
]
Expand Down

0 comments on commit 0ac2d54

Please sign in to comment.