Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Katy Jarvis <55932920+kjjarvis@users.noreply.github.com>
  • Loading branch information
aqitya and kjjarvis authored Aug 8, 2023
1 parent 130441e commit a210bf9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions examples/benchmarking.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Then, for our model, we would need to define a future loading function. More information on what a future loading function is and how to use it can be found here: https://nasa.github.io/progpy/prog_models_guide.html#future-loading"
"Then, for our model, we will need to define a future loading function. More information on what a future loading function is and how to use it can be found here: https://nasa.github.io/progpy/prog_models_guide.html#future-loading"
]
},
{
Expand Down Expand Up @@ -103,9 +103,9 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Finally, we are going to need to benchmark the simulation!\n",
"Finally, we are ready to benchmark the simulation.\n",
"\n",
"We can do this by using the `timeit()` function and pass in our `simulate_to()` or `simulate_to_threshold()` function for the `stmt` argument. For more information regarding the `timeit()` function, please read it's documentation located here: https://docs.python.org/3/library/timeit.html"
"We can do this by using the `timeit()` function and pass in our `simulate_to()` or `simulate_to_threshold()` function for the `stmt` argument. For more information regarding the `timeit()` function, please read its documentation located here: https://docs.python.org/3/library/timeit.html"
]
},
{
Expand All @@ -125,7 +125,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"In this example, we would be benchmarking the simulation for the BatteryCircuit model up to 600 seconds. Furthermore, we will define our `number` argument to be 500 for sake of runtime."
"In this example, we are benchmarking the simulation for the BatteryCircuit model up to 600 seconds. Furthermore, we define our `number` argument to be 500 for sake of runtime."
]
},
{
Expand Down

0 comments on commit a210bf9

Please sign in to comment.