Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Composite parameters #143

Closed
5 tasks done
teubert opened this issue Jul 5, 2024 · 0 comments · Fixed by #144
Closed
5 tasks done

Improved Composite parameters #143

teubert opened this issue Jul 5, 2024 · 0 comments · Fixed by #144
Assignees
Labels
components: models enhancement New feature or request project: SWS System Wide Safety Project

Comments

@teubert
Copy link
Contributor

teubert commented Jul 5, 2024

Requirement Text
Allow the setting of composed model parameters in a CompositeModel

Background Information
Right now the composite model expects that you set the parameters either before creation or by accessing m.parameters['models'].parameters. This is 1. messy and 2. doesn't work with prog_server.

Suggested Solution
Parse parameters using 'model_name.parameter' so m.parameters['abc.def'] would set m.parameters['model'].parameters['def'].

DoD

  • Implement feature
  • Add to example
  • Add tests
  • update documentation
  • Add to change notes for next release
@teubert teubert added the enhancement New feature or request label Jul 5, 2024
@teubert teubert added this to the v1.7: Fall 2024 release milestone Jul 5, 2024
@teubert teubert self-assigned this Jul 5, 2024
@teubert teubert added components: models project: SWS System Wide Safety Project labels Jul 5, 2024
@teubert teubert linked a pull request Jul 5, 2024 that will close this issue
@teubert teubert closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components: models enhancement New feature or request project: SWS System Wide Safety Project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant