-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite Model Parameter #144
Conversation
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition!
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"Parameters in composed models can be updated directly using the model_name.parameter name parameter of the composite model. Like so:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "model_name.parameter name" be "model_name['parameter name']" to match the code below it? (perhaps either syntax would work?)
7.3 kB was a bit excessive a req.
Closes #143
Updated composite model so that setting parameters in the composite model will update the composed models. For example, setting "abc.def" will update parameter "def" of composed model "abc".
Also added to jupyter notebook and added test.
This feature was requested by the SWS project for a model of their SWS Safety Service