Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemble Model example #106

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Ensemble Model example #106

merged 4 commits into from
Oct 11, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Oct 7, 2023

Added example for ensemble model to notebook 06

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Merging #106 (db7d66a) into dev (707f9fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #106   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          99       99           
  Lines       10183    10183           
=======================================
  Hits         8574     8574           
  Misses       1609     1609           

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. Just a few suggestions to add clarity

examples/06_Combining_Models.ipynb Outdated Show resolved Hide resolved
examples/06_Combining_Models.ipynb Outdated Show resolved Hide resolved
examples/06_Combining_Models.ipynb Outdated Show resolved Hide resolved
examples/06_Combining_Models.ipynb Outdated Show resolved Hide resolved
examples/06_Combining_Models.ipynb Outdated Show resolved Hide resolved
examples/06_Combining_Models.ipynb Show resolved Hide resolved
@teubert teubert merged commit 0a83b4f into dev Oct 11, 2023
28 checks passed
@teubert teubert deleted the examples/ensemble branch October 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants