Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noise transfer #137

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix noise transfer #137

merged 2 commits into from
Dec 20, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Dec 20, 2023

Fixes a bug where when noise is transferred from one model to another (i.e., the noise from one model is used to set the other), the missing keys in *_noise are not set, because the object is already a DictLikeMatrix wrapper.

This becomes an issue with models with dynamic states and events. The first of these models is being tested in the SWS project

@teubert teubert added bug Something isn't working project: SWS System Wide Safety Project labels Dec 20, 2023
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@teubert teubert merged commit 951cdfc into dev Dec 20, 2023
28 of 29 checks passed
@teubert teubert deleted the bug/noise_transfer branch December 21, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project: SWS System Wide Safety Project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants