Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite Model - Add function return in output #139

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Dec 20, 2023

Add returns of composite model function members to composite model output.

@teubert teubert added the project: SWS System Wide Safety Project label Dec 20, 2023
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec48258) 83.29% compared to head (ec48258) 83.29%.

❗ Current head ec48258 differs from pull request most recent head a367143. Consider uploading reports for the commit a367143 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #139   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files         100      100           
  Lines       10507    10507           
=======================================
  Hits         8752     8752           
  Misses       1755     1755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teubert teubert merged commit 31af475 into dev Dec 21, 2023
28 of 30 checks passed
@teubert teubert deleted the feature/138-composite-model-function-output branch February 15, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: SWS System Wide Safety Project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants