Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calc Error Extension #165

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Calc Error Extension #165

merged 1 commit into from
Nov 4, 2024

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Nov 4, 2024

Simple error to calc error MSE where it now gives a "penalty" for the model going unstable before completing sim. The result is that parameter estimation first finds parameters that will be able to complete prediction, then it will refine them.

Copy link

github-actions bot commented Nov 4, 2024

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition of penalty in MSE calculation

@teubert teubert merged commit a9edf31 into dev Nov 4, 2024
27 of 31 checks passed
@teubert teubert deleted the feature/calc_error_extension branch November 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants