Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linear model Jupyter Notebook #70

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add linear model Jupyter Notebook #70

merged 2 commits into from
Jul 18, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Jul 18, 2023

Add linear model jupyter notebook developed by @aqitya and approved here: nasa/prog_models#551 (review)

The only changes from this approved PR are:

  1. Removed old linear model example (that this replaces), and
  2. changed prog_models -> progpy in import

@teubert teubert requested a review from aqitya July 18, 2023 16:33
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #70 (2b78b18) into dev (1485c8a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #70   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          99       99           
  Lines       10111    10111           
=======================================
  Hits         8513     8513           
  Misses       1598     1598           

@aqitya
Copy link
Contributor

aqitya commented Jul 18, 2023

Pushed some changes to how we were directing users to ProgPy documentation.

@teubert
Copy link
Contributor Author

teubert commented Jul 18, 2023

I reviewed @Aqity's pushed changed and approve

@teubert teubert merged commit 7e9b223 into dev Jul 18, 2023
27 of 28 checks passed
@teubert teubert deleted the tests/linear_model branch August 7, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants