Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Param Est Example #80

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Rename Param Est Example #80

merged 2 commits into from
Aug 22, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Aug 21, 2023

Part of the numbering of examples with the example ordering effort.

@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@teubert
Copy link
Contributor Author

teubert commented Aug 22, 2023

This is just renaming an example file. I've determined that a review isn't necessary and am waiving the requirement

@teubert teubert merged commit a421b92 into dev Aug 22, 2023
11 checks passed
@teubert teubert deleted the examples/param_est branch August 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant