Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples/horizon notebook #93

Closed
wants to merge 2 commits into from
Closed

Examples/horizon notebook #93

wants to merge 2 commits into from

Conversation

kjjarvis
Copy link
Contributor

Added notebook for prediction horizon feature. This is a slightly edited version of @aqitya's work.

Note: this notebook may not be included in the final released version of progpy, but is a template to be adjusted to fit our new example format.

@kjjarvis kjjarvis requested a review from teubert August 31, 2023 22:04
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also rename this file to 09_Prediction? Then you can create a first heading # Prediction and set Prediction Horizon to second level heading?

@teubert
Copy link
Contributor

teubert commented Sep 13, 2023

This was replaced with #94

@teubert teubert closed this Sep 13, 2023
@teubert teubert deleted the examples/horizon_notebook branch September 13, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants