Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding serialization example #95

Closed
wants to merge 1 commit into from
Closed

Conversation

kjjarvis
Copy link
Contributor

@kjjarvis kjjarvis commented Sep 8, 2023

Adding an example illustrating how to serialize and deserialize models

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

Codecov Report

Merging #95 (10b3dd4) into dev (f20aa05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #95   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files          99       99           
  Lines       10178    10178           
=======================================
  Hits         8573     8573           
  Misses       1605     1605           

📢 Have feedback on the report? Share it here.

@kjjarvis kjjarvis closed this Oct 11, 2023
@kjjarvis
Copy link
Contributor Author

This PR is closed because it was moved to PR #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants