Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wedge load noise #97

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Wedge load noise #97

merged 3 commits into from
Sep 15, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Sep 13, 2023

Add "wedge noise" - that is, noise that increases the further we are in the future.

This is an important feature as it allows us to represent how our uncertainty in the future load increases the further out we are.

Also, renamed GaussianNoiseLoadWrapper to GaussianNoiseWrapper for conciseness. It's still in the loading sub package (progpy.loading.GaussianNoiseWrapper) so "Load" wasn't necessary. I leave an alias for backwards compatibility, but the documentation and examples will use GaussianNoiseWrapper.

Closes #84

@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #97 (1057c3c) into dev (0c23145) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev      #97      +/-   ##
==========================================
- Coverage   84.22%   84.19%   -0.03%     
==========================================
  Files          99       99              
  Lines       10179    10183       +4     
==========================================
+ Hits         8573     8574       +1     
- Misses       1606     1609       +3     
Files Changed Coverage Δ
src/progpy/loading/gaussian_wrapper.py 37.50% <42.85%> (-4.17%) ⬇️
src/progpy/loading/__init__.py 100.00% <100.00%> (ø)

@teubert teubert linked an issue Sep 13, 2023 that may be closed by this pull request
5 tasks
@teubert teubert merged commit b9613b4 into dev Sep 15, 2023
29 checks passed
@teubert teubert deleted the feature/guassian_wedge branch September 15, 2023 17:00
@teubert teubert mentioned this pull request Oct 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wedge Gaussian Load Wrapper
3 participants