fix dev flag

natemoo-re · Nov 25, 2024 · 944b9b8 · 944b9b8
1 parent d35385c
commit 944b9b8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -5,7 +5,7 @@ export default function createIntegration(): AstroIntegration {
   return {
     name: "astro-icon",
     hooks: {
-      "astro:config:setup"({ updateConfig, config, logger }) {
+      "astro:config:setup"({ updateConfig, command, config, logger }) {
         updateConfig({
           experimental: {
             svg: config.experimental?.svg ?? { mode: "inline" },
@@ -16,6 +16,7 @@ export default function createIntegration(): AstroIntegration {
                 cacheDir: config.cacheDir,
                 logger,
                 experimental: config.experimental,
+                __DEV__: command === "dev",
               }),
             ],
           },

diff --git a/packages/core/src/utils/icon.ts b/packages/core/src/utils/icon.ts
@@ -27,7 +27,7 @@ function getIconifyUrl(collection: string) {
 
 async function fetchCollection(
   collection: string,
-  { cache }: { cache: FileCache }
+  { cache, __DEV__ }: { cache: FileCache; __DEV__: boolean }
 ): Promise<IconCollection> {
   let collectionData = await cache.read<IconCollection>(collection);
   if (collectionData) {
@@ -45,7 +45,7 @@ async function fetchCollection(
     const err = new AstroIconError(
       `Unable to locate the icon collection "${collection}"`
     );
-    if (import.meta.env.DEV) {
+    if (__DEV__) {
       err.hint = `The "${collection}" icon collection does not exist.\n\nIs this a typo?`;
     }
     throw err;
@@ -58,17 +58,21 @@ async function fetchCollection(
 export async function getIconData(
   collection: string,
   name: string,
-  { cache, logger }: { cache: FileCache; logger: AstroIntegrationLogger }
+  {
+    cache,
+    logger,
+    __DEV__,
+  }: { cache: FileCache; logger: AstroIntegrationLogger; __DEV__: boolean }
 ): Promise<IconData | undefined> {
-  const collectionData = await fetchCollection(collection, { cache });
+  const collectionData = await fetchCollection(collection, { cache, __DEV__ });
 
   const { icons, aliases } = collectionData;
   const icon = icons[name] ?? aliases[name];
   if (icon === undefined) {
     const err = new AstroIconError(
       `Unable to locate the icon "${collection}:${name}"`
     );
-    if (import.meta.env.DEV) {
+    if (__DEV__) {
       err.hint = `The "${collection}" icon collection does not include an icon named "${name}".\n\nIs this a typo?`;
     }
     throw err;

diff --git a/packages/core/src/vite-plugin-astro-icon.ts b/packages/core/src/vite-plugin-astro-icon.ts
@@ -7,6 +7,7 @@ import { AstroIconError } from "./utils/error.js";
 
 interface PluginOptions extends Pick<AstroConfig, "cacheDir" | "experimental"> {
   logger: AstroIntegrationLogger;
+  __DEV__: boolean;
 }
 
 const DEFAULT_ICON_SIZE = 24;
@@ -17,6 +18,7 @@ export function createPlugin({
   cacheDir,
   logger,
   experimental,
+  __DEV__,
 }: PluginOptions): Plugin {
   const cache = new FileCache(new URL("astro-icon/icons/", cacheDir), logger);
 
@@ -33,7 +35,11 @@ export function createPlugin({
         const [collection, icon] = name.split("/");
 
         try {
-          const data = await getIconData(collection, icon, { cache, logger });
+          const data = await getIconData(collection, icon, {
+            cache,
+            logger,
+            __DEV__,
+          });
           if (!data) return;
 
           const {