(refactor) some opportunities to use lambda functions #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@desmorto you might want to make your pull request against the Apache version of storm that is under active development. |
|
In such clear cases, what's the advantage of |
roldevg
reviewed
Aug 17, 2018
| @@ -59,9 +59,9 @@ public IConnection connect(String storm_id, String host, int port) { | |||
| * terminate this context | |||
| */ | |||
| public void term() { | |||
| for (IConnection conn : connections) { | |||
| connections.forEach(conn -> { | |||
There was a problem hiding this comment.
@desmorto, You can remove unnecessary brackets or use a method reference.
connections.forEach(conn -> conn.close());
roldevg
reviewed
Aug 17, 2018
| for (List<Object> key : keys) { | ||
| ret.add(db.get(key)); | ||
| } | ||
| keys.forEach(key -> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.