Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install dj-database-url #1

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Install dj-database-url #1

merged 1 commit into from
Nov 26, 2024

Conversation

tm-kn
Copy link
Collaborator

@tm-kn tm-kn commented Nov 12, 2024 •
edited
Loading

  • We're deploying to Heroku initially so it makes sense to me to use dj-database-url to interpret DATABASE_URL environment variable.
  • Added a custom isort config to isolate third-party dependencies from the first-party dependencies.

patrickcuagan
patrickcuagan approved these changes Nov 20, 2024
View reviewed changes
Copy link

@patrickcuagan patrickcuagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@tm-kn tm-kn merged commit 268b7b2 into main Nov 26, 2024
6 checks passed
@tm-kn tm-kn deleted the chore/database-url branch November 26, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickcuagan patrickcuagan patrickcuagan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tm-kn @patrickcuagan