[TDRD 87] Row validation error report download compatibility tweaks #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
annielh
commented
Nov 18, 2024
•
annielh
commented
- Rename Field -> Column as requested by @TNAemmaPea
- Put row validation errors at the top of error report
- The asset id will now be the file path by default so we can use it directly for the identifier (Filepath) column.
annielh
changed the title
TomJKing
reviewed
Nov 19, 2024
| @@ -134,15 +134,19 @@ class DraftMetadataChecksResultsController @Inject() ( | |||
| reference <- consignmentService.getConsignmentRef(consignmentId, request.token.bearerAccessToken) | |||
| errorReport <- draftMetadataService.getErrorReport(consignmentId) | |||
| } yield { | |||
| val orderingPrioritisingRowErrors: Ordering[Error] = | |||
There was a problem hiding this comment.
Could this be made a bit more configurable so the priory error type is not static? Something like this:
...
def downloadErrorReport(consignmentId: UUID, priorityErrorType: FileError = ROW_VALIDATION): Action[AnyContent] = standardUserAndTypeAction(consignmentId) { implicit request: Request[AnyContent] =>
for {
...
} yield {
val orderingPriorityErrors: Ordering[Error] =
Ordering.by[Error, (Boolean, String)](e => (!e.validationProcess.equals(s"$priorityErrorType"), e.validationProcess))
...
TomJKing
reviewed
Nov 19, 2024
| reference <- consignmentService.getConsignmentRef(consignmentId, request.token.bearerAccessToken) | ||
| errorReport <- draftMetadataService.getErrorReport(consignmentId) | ||
| } yield { | ||
| val orderingPrioritisingRowErrors: Ordering[Error] = |
There was a problem hiding this comment.
Should rename this val to something less specific given it might not always be row errors with priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.