Datetime fxns #53
Merged
Datetime fxns #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 15, 2023 17:37
added 2 commits
November 17, 2023 09:32
Only works if fix_utc_offset is used when reading date/time strings
RobLBaker
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Looks good! Thanks for slogging through date/times
RobLBaker
reviewed
Dec 19, 2023
R/dates_and_times.R
Outdated
| #' fix_utc_offset(datetimes) # returns c("2023-11-16T03:32:49+0700", "2023-11-16T03:32:49-0700", "2023-11-16T03:32:49", "2023-11-16T03:32:49+0000") and warns about missing offset (see third element) | ||
| #' | ||
| fix_utc_offset <- function(datetime_strings) { | ||
| datetime_strings <- stringr::str_replace_all(datetime_strings, "[−‐‑‒–—―﹘﹣－]", "-") # replace every possible type of dash with a regular minus sign |
There was a problem hiding this comment.
looks like non-ascii characters, likely in this line mucking up the package build.
RobLBaker
reviewed
Dec 19, 2023
| fix_utc_offset <- function(datetime_strings) { | ||
| datetime_strings <- stringr::str_replace_all(datetime_strings, "[−‐‑‒–—―﹘﹣－]", "-") # replace every possible type of dash with a regular minus sign | ||
|
|
||
| datetime_strings <- stringr::str_replace_all(datetime_strings, "[\u2212\u2010\u2011\u2012\u2013\u2014\u2015\ufe58\ufe63\uff0d]", "-") # replace every possible type of dash with a regular minus sign |
RobLBaker
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fxn to make ISO 8601 formatted strings have R-friendly UTC offsets. In theory it shouldn't do anything to strings with no UTC offset.
Also moved convert_datetime_format to this package and fixed one of the regular expressions that had been commented out. Added a regular expression to replace UTC offset indicators (e.g. -hh, -hhhh) with %z. We should talk about how to handle format strings with "Z" to indicate UTC+0000 before you accept this PR.