Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved P flag summary #84

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

sarahkelso
Copy link
Collaborator

Moved P flag summary to after R flag summary to fix issue in DRR with inconsistent flag order in tables

@sarahkelso sarahkelso changed the title Moved P flag smmary Moved P flag summary Mar 20, 2024
@RobLBaker
Copy link
Member

I couldn't find any inconsistency in the order of the columns in the DRR tables. Two tables have flagged columns, Table 3 and Table 4.

Table 3 columns are: File Name, Measure, Number of Records, A, AE, R, P, % Accepted.
Table 4 columns are: File Name, A, AE, R, P, % Accepted.

Is there some other place I should be looking for inconsistencies?

@sarahkelso
Copy link
Collaborator Author

I couldn't find any inconsistency in the order of the columns in the DRR tables. Two tables have flagged columns, Table 3 and Table 4.

Table 3 columns are: File Name, Measure, Number of Records, A, AE, R, P, % Accepted. Table 4 columns are: File Name, A, AE, R, P, % Accepted.

Is there some other place I should be looking for inconsistencies?

You'll only notice the difference if you have any Rejected items in the flagged columns. In table 4 when you knit the DRR any R stats show up under P, and if you run just dp_flags <- QCkit::get_custom_flags(directory = here::here("DataPackage"), output="files") in R to produce the table, it shows that the order of the columns for table 4 is actually A, AE, P, R, % Accepted. When knitted, P and R and given opposite labels in table 4 so it appears to be the same as table 3 until you have Rejected data showing up under P.

@codecov-commenter

This comment was marked as spam.

@RobLBaker RobLBaker merged commit 37ea698 into nationalparkservice:master Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants