Copy CRDs into the crds directory of the NACK chart
#694
Conversation
|
Could this PR be merged please. Very useful when you deploy everything via GitOps |
|
What do you think about moving the chart into the main project and then push releases here? Then we have everything on the sample place and make updating things easier. |
|
Can this be merged, or alternatively solved in some other way? Having to maintain a copy of the CRDs is tedious and error-prone. |
|
Would love to update the PR (update CRD if necessary and fix merge conflicts) after a maintainer gives a thumbs up on this rather small, non-breaking change. |
|
@dfr-exnaton what do you think to add |
This PR just copied over the crds to include them in the chart, nothing was modified. Do you have an example where this annotation would help? Because I could also see issues when keeping resources around... |
|
@caleblloyd would be great if this minor PR can either get a thumbs up or thumbs down. If positive, I would obviously update the README and the crds to be in sync (after more than one year...) |
|
A bit frustrating that in 2024 we still need to copy-paste CRDs while many other charts include them by default. |
Summary
Based on the discussions in #398, this PR copies the required CRDs for NACK into the special
crdsdirectory of NACK helm chart and updates the README as well as the tests. Drawback is the increased maintenance in keeping the CRDs in sync with thenackrepo.Motivation
In my opinion, providing a caveat that CRDs have to be manually upgraded as part of a chart upgrade is necessary also when no
crdsdirectory is used. Thus its more user friendly if CRDs are provided as part of the chart. Not having an extra step to manually install & maintain CRDs when using this chart is also super helpful for GitOps users. Flux for example specifically has a special configuration object that allows to reinstall CRDs as part of an chart upgrade.