Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nats-Kafka Service Account Support #853

Merged

Conversation

ChrisDizenzo1047
Copy link
Contributor

Description

The Nats-Kafka _helpers.tpl already had the service account setup, but it seemed incomplete:

{{/*
Create the name of the service account to use
*/}}
{{- define "nats-kafka.serviceAccountName" -}}
{{- if .Values.serviceAccount.create }}
{{- default (include "nats-kafka.fullname" .) .Values.serviceAccount.name }}
{{- else }}
{{- default "default" .Values.serviceAccount.name }}
{{- end }}
{{- end }}

There was no usage of nats-kafka.serviceAccountName, so this PR just adds the usage of that. If create is true it creates a service account, if not it uses the value from serviceAccount.name.

Testing

Tested the helm chart from our internal branch and worked as intended.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 2a79e72 into nats-io:main Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants