Nats-Kafka Service Account Support #853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Nats-Kafka
_helpers.tpl
already had the service account setup, but it seemed incomplete:There was no usage of
nats-kafka.serviceAccountName
, so this PR just adds the usage of that. If create is true it creates a service account, if not it uses the value from serviceAccount.name.Testing
Tested the helm chart from our internal branch and worked as intended.