Direct batch and multi last client API and examples #310
Conversation
scottf
requested review from
ripienaar,
mtmk,
aricart,
Jarema,
piotrpio and
MauriceVanVeen
scottf
changed the title
| * API: `batch: number, max_bytes: number, sequence: number, subject: string` | ||
| * Request: `{"batch":3,"max_bytes":2002,"seq":4,"next_by_subj":"foo.>"}` | ||
| 1. gets up to batch number of messages >= than start time that has specified subject, limited by max bytes | ||
| * API: `batch: number, max_bytes: number, start time: time, subject: string` |
There was a problem hiding this comment.
start_time is not supported in batch requests (possibly should be)
There was a problem hiding this comment.
I have unit tests that say otherwise.
There was a problem hiding this comment.
There was a problem hiding this comment.
I have unit tests for all of these and they all work as expected.
- batch only
- batch with starting sequence
- batch with start time
- batch with max bytes
- batch with max bytes and starting sequence
- batch with max bytes and start time
For multi last I have these tests
- just subjects
- subjects with up_to_seq
- subjects with up_to_time
Here is the server validation code (Stream.go line 4266):
// Check we don't have conflicting options set.
// We do not allow batch mode for lastFor requests.
if (req.Seq > 0 && req.LastFor != _EMPTY_) ||
(req.Seq > 0 && req.StartTime != nil) ||
(req.StartTime != nil && req.LastFor != _EMPTY_) ||
(req.LastFor != _EMPTY_ && req.NextFor != _EMPTY_) ||
(req.LastFor != _EMPTY_ && req.Batch > 0) ||
(req.LastFor != _EMPTY_ && len(req.MultiLastFor) > 0) ||
(req.NextFor != _EMPTY_ && len(req.MultiLastFor) > 0) ||
(req.UpToSeq > 0 && req.UpToTime != nil) {
hdr := []byte("NATS/1.0 408 Bad Request\r\n\r\n")
mset.outq.send(newJSPubMsg(reply, _EMPTY_, _EMPTY_, hdr, nil, nil, 0))
return
}
Relevant notes on that code
- seq and last for cannot both be present
- seq and start time cannot both be present
- up_to_seq and up_to_time cannot both be present
There was a problem hiding this comment.
It appears that batch works to limit the multi_for response, so I have to add these variants in
There was a problem hiding this comment.
Need to do more investigation, but for direct batch:
multi_lastbatchseqmax_bytes- (
up_to_seq|up_to_time) - they are mutually exclusive
Only multi_last is required.
All the other options can be specified in the query - however only one of up_to kind can be specified.
A better way to understand is that a batch:
- Always has a multiple filter specified (can be
[">"]) - Can specify a start
seq(otherwise grabs from the end of the stream) - Can specify multiple limits at the same time:
batch,max_bytesand a one more sentinel conditionup_to_seqorup_to_time
|
Added multi last for variants with batch |
| @@ -115,6 +115,30 @@ After the batch is sent a zero length payload message will be sent with the `Nat | |||
|
|
|||
| When requests are made against servers that do not support `batch` the first response will be received and nothing will follow. Old servers can be detected by the absence of the `Nats-Num-Pending` header in the first reply. | |||
|
|
|||
| There are 4 viable API calls for a batch. All require a batch amount greater than 0 and a subject which may include a wildcard. | |||
There was a problem hiding this comment.
This should now be 6* viable API calls.
No description provided.