Pause and Resume consumer #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtmk
reviewed
Mar 7, 2024
| @@ -144,7 +144,8 @@ public static DateTime AsDate(JSONNode node) | |||
| { | |||
| try | |||
| { | |||
| return DateTime.Parse(node.Value).ToUniversalTime(); | |||
| DateTime dt = DateTime.Parse(node.Value).ToUniversalTime(); | |||
| return dt.Year == 1 ? DateTime.MinValue : dt; // b/c server sends a value that doesn't quite parse to DateTime.MinValue | |||
There was a problem hiding this comment.
DateTime.MinValue.ToUniversalTime() resolves to 1/1/0001 5:00:00 AM
But for whatever reason the value the server sends 0001-01-01T00:00:00Z when resolved with
DateTime.Parse(node.Value).ToUniversalTime()
ends up with 1/2/0001 12:00:00 AM
So I decdide that anything with year 1 must have meant min value. I can't imagine real server date data will have a date of year 1.
There was a problem hiding this comment.
I think I'm going to do it a different way and revert this. I can check if paused is false when reading the json, and if it is, then I don't even need to parse the time. This is really an issue with JSONNode
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/nats-io/nats.net/issues/867
Adds support for pausing and resuming consumers.
IJetStreamManagementnow has methods tojsm.PauseConsumer(stream, consumer, pauseUntil), as well asjsm.ResumeConsumer(stream, consumer).src/examples.ConsumerConfiguration/builder now has support for settingpauseUntilas well. Allowing to set it during consumer creation.