Consume clean exit fixes #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enlarge subscription channel to avoid blocking other socket reads on the same connection. * Pass cancellation token to Consume() so it can be gracefully stopped. * 'Consume' can also be gracefully stopped when Stop() is called. * There is no graceful stop for 'Fetch' since we have no option but wait for the single pull request to complete. * Disposing the 'Consume' or 'Fetch' would exit loops a.s.a.p.
caleblloyd
approved these changes
Oct 20, 2023
| { | ||
| while (!cts.Token.IsCancellationRequested) | ||
| { | ||
| try | ||
| { | ||
| Console.WriteLine($"___\nFETCH {maxMsgs}"); | ||
| await consumer.RefreshAsync(cts.Token); | ||
| await using var sub = await consumer.FetchAsync<RawData>(fetchOpts, cts.Token); | ||
| await using var sub = await consumer.FetchAsync<IMemoryOwner<byte>>(fetchOpts, cts.Token); |
There was a problem hiding this comment.
If you are a fan of #162 you may want to convert these examples!
mtmk
added a commit
that referenced
this pull request
Oct 20, 2023
mtmk
added a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enlarge subscription channel to avoid blocking other socket reads on the same connection.
Pass cancellation token to Consume() so it can be gracefully stopped.
'Consume' can also be gracefully stopped when Stop() is called.
There is no graceful stop for 'Fetch' since we have no option but wait for the single pull request to complete.
Disposing the 'Consume' or 'Fetch' would exit loops a.s.a.p.