Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordered consumer optimizations #336

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Ordered consumer optimizations #336

merged 2 commits into from
Jan 17, 2024

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Jan 17, 2024

  • Pull channel optimization
  • Reduce consume method complexity

With this fix ordered consumer message rate goes up x2.

@mtmk
Ordered consumer optimizations
2bd3c31 
* Pull channel optimization
* Reduce consume method complexity
@mtmk mtmk linked an issue Jan 17, 2024 that may be closed by this pull request
Ordered consumer is too slow #333
Closed
@mtmk mtmk requested a review from caleblloyd January 17, 2024 14:11
@caleblloyd
Copy link
Collaborator

looks like it may need a dotnet format

@caleblloyd
Copy link
Collaborator

I opened #338 to address formatting issues, I don't think they were caused by this PR. LGTM

@caleblloyd
Copy link
Collaborator

you beat me to it 😄 I'll rebase after you merge

@mtmk mtmk merged commit b503fd5 into main Jan 17, 2024
7 of 9 checks passed
@mtmk mtmk deleted the 333-ordered-consumer-is-too-slow branch January 17, 2024 15:32
mtmk added a commit that referenced this pull request Jan 17, 2024
@mtmk
Release 2.1.0-preview.3
f4dc38d 
* Ordered consumer optimizations (#336)
* Addition of factories for better testability. (#330)
* Nullability review for models (#332)
* Support Keyed DI services in .NET 8 (#331)
* (not merged yet) TLS auth timeout (#339)
@mtmk mtmk mentioned this pull request Jan 17, 2024
Merged
mtmk added a commit that referenced this pull request Jan 18, 2024
@mtmk
Release 2.1.0-preview.3 (#340)
199c242 
* Ordered consumer optimizations (#336)
* Addition of factories for better testability. (#330)
* Nullability review for models (#332)
* Support Keyed DI services in .NET 8 (#331)
* (not merged yet) TLS auth timeout (#339)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ordered consumer is too slow
2 participants
@mtmk @caleblloyd