throw away bytes in send buffer after a failed send #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
mtmk
added a commit
that referenced
this pull request
Feb 2, 2024
* Send buffer refinements * Command writer pipeline encapsulation * Default write buffer size * Revert tmp comment outs * HPUB writer fix * Use channel instead of semaphore for locks * Reuse same pipeline avoiding data loss * Tidy up * Reverted ping command * Revert to clearing buffer Other NATS clients do the same * Lock function * Added inlining * Command timeouts * Cancellation fixes * Derive pool rent size from buffer size option * Fixed format * Command timeout test * Test debug * Keep send buffer at message boundaries * Flush buffers cleanly on dispose * Fixing buffer msg boundry issue * Format fixed * Buffer position * Handle socket exception * throw away bytes in send buffer after a failed send (#368) Signed-off-by: Caleb Lloyd <caleb@synadia.com> --------- Signed-off-by: Caleb Lloyd <caleb@synadia.com> Co-authored-by: Caleb Lloyd <2414837+caleblloyd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have no idea if bytes in send buffer were actually sent on a failed
SendAsync