Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject payloads over the threshold set by server #378

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Reject payloads over the threshold set by server #378

merged 2 commits into from
Feb 7, 2024

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Feb 7, 2024 •
edited
Loading

Proactively reject payloads over the threshold set by server.

Go client reference:
https://github.com/nats-io/nats.go/blob/f42d2be72a8e21f8f684f002a870eefb852ec937/nats.go#L3761

@mtmk mtmk requested a review from caleblloyd February 7, 2024 13:13
@mtmk mtmk linked an issue Feb 7, 2024 that may be closed by this pull request
Sending too large payloads causes timeouts #376
Closed
caleblloyd
caleblloyd approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 4ab46d2 into main Feb 7, 2024
9 of 10 checks passed
@mtmk mtmk deleted the 376-sending-too-large-payloads-causes-timeouts branch February 7, 2024 14:42
mtmk added a commit that referenced this pull request Feb 8, 2024
@mtmk
Release 2.1.0-preview.7
6f8ce6d 
* Send buffer fix (#380)
* Publish - avoid async state machine when possible (#373)
* Reject payloads over the threshold set by server (#378)
* Fix NatsSvcServer start time format so that it's no longer culture aware (#374)
* Expose Headers on NatsSvcMsg (#371)
@mtmk mtmk mentioned this pull request Feb 8, 2024
Merged
mtmk added a commit that referenced this pull request Feb 8, 2024
@mtmk
Release 2.1.0-preview.7 (#382)
5e66e0b 
* Send buffer fix (#380)
* Publish - avoid async state machine when possible (#373)
* Reject payloads over the threshold set by server (#378)
* Fix NatsSvcServer start time format so that it's no longer culture aware (#374)
* Expose Headers on NatsSvcMsg (#371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending too large payloads causes timeouts
2 participants
@mtmk @caleblloyd