Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix telemetry header readonly error #719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix telemetry header readonly error #719

wants to merge 2 commits into from
+202 −3

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Jan 17, 2025

@mtmk mtmk mentioned this pull request Jan 17, 2025
Open
mtmk
mtmk commented Jan 17, 2025
View reviewed changes
src/NATS.Client.Core/NatsConnection.Publish.cs
@@ -11,6 +11,7 @@ public ValueTask PublishAsync(string subject, NatsHeaders? headers = default, st
if (Telemetry.HasListeners())
{
using var activity = Telemetry.StartSendActivity($"{SpanDestinationName(subject)} {Telemetry.Constants.PublishActivityName}", this, subject, replyTo);
Telemetry.AddTraceContextHeaders(activity, ref headers);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update on ReadOnly Headers after Retry
1 participant
@mtmk