Retry endpoint after the initial connection was refused #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinier Schoof <reinier@skoef.nl>
|
@wallyqs perhaps you can take a look? |
|
@piotrpio perhaps you could take a look to this PR? |
piotrpio
reviewed
Oct 28, 2023
| @@ -302,6 +302,13 @@ func (nc *NATSCollector) initMetricsFromServers(namespace string) { | |||
| } | |||
| } | |||
|
|
|||
| if response == nil && retryTime > 0 { | |||
There was a problem hiding this comment.
This will only retry once, which seems may solve the problem sometimes but in general I would think we should do it in a loop to wait until we've got some response.
I think it may be good to add an option like e.g. --max-retries to be able to bail out, but that can be done in a separate PR since it owuld also apply to other places where opts.RetryInterval is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kubernetes environments, when the nats-exporter is running as a sidecar, the nats-exporter might be probing the NATS server before it is running. This will prevent collectors for those endpoints to be made.
This PR fixes this by retrying to the NATS server once after it initially failed. This should solve issue #133