Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added integration test that would close #102 #216

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added integration test that would close #102 #216

wants to merge 2 commits into from

Conversation

tsm1th
Copy link
Contributor

@tsm1th tsm1th commented Jul 17, 2024

This integration test would close #102.

@tsm1th tsm1th requested a review from joewesch July 17, 2024 15:49
@tsm1th
Copy link
Contributor Author

tsm1th commented Jul 17, 2024

@jeffkala - I don't know if this is feasible or not. The CI pipeline keeps failing for reasons mentioned here. I could see this being an intermittent failure to the pipeline going forward with it's dependency on the celery worker. Thoughts?

@jvanderaa
Copy link
Contributor

What if we moved them all to requests mock?

@joewesch
Copy link
Contributor

What if we moved them all to requests mock?

I think you're thinking of a unit test. The request was for an integration test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewesch joewesch Awaiting requested review from joewesch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration test for jobs run method
3 participants
@tsm1th @jvanderaa @joewesch