Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VurderLivshendelse tar i bruk minimal restfagsak #1001

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

stigebil
Copy link
Contributor

@stigebil stigebil commented Dec 19, 2023

Fikser bug for vurder livshendelse for Kontantstøtte. Tar i bruk minimal restfagsak for vurderlivshendelse. KS hadde ikke tjenesten som henter hele restfagsaken, men den minimale gir oss alt vi trenger.

Tar i bruk minimal restfagsak for vurderlivshendelse, siden KS ikke hadde tjenesten som henter hele fagsaken og den minimale gir oss alt vi trenger
@stigebil stigebil requested a review from a team as a code owner December 19, 2023 12:47
@@ -172,6 +172,8 @@ data class RestMinimalFagsak(
class RestVisningBehandling(
val behandlingId: Long,
val opprettetTidspunkt: LocalDateTime,
val kategori: BehandlingKategori,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leveres av både ks og ba

@@ -172,6 +172,8 @@ data class RestMinimalFagsak(
class RestVisningBehandling(
val behandlingId: Long,
val opprettetTidspunkt: LocalDateTime,
val kategori: BehandlingKategori,
val underkategori: BehandlingUnderkategori?,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denne er null for KS

Copy link
Contributor

@halvorbmundal halvorbmundal Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan vi dokumentere dette gjennom typer? F.eks:

sealed class RestVisningBehandling(
    val behandlingId: Long,
    val opprettetTidspunkt: LocalDateTime,
    val kategori: BehandlingKategori,
    val aktiv: Boolean,
    val årsak: String? = null,
    val type: String,
    val status: String,
    val resultat: String? = null,
    val vedtaksdato: LocalDateTime? = null
) {
    data class Ba(
        val underkategori: BehandlingUnderkategori
    ) : RestVisningBehandling(
        behandlingId,
        opprettetTidspunkt,
        kategori,
        aktiv,
        årsak,
        type,
        status,
        resultat,
        vedtaksdato
    )

    data class Ks : RestVisningBehandling(
        behandlingId,
        opprettetTidspunkt,
        kategori,
        aktiv,
        årsak,
        type,
        status,
        resultat,
        vedtaksdato
    )
}

@stigebil stigebil added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 2a103db Jan 2, 2024
6 checks passed
@stigebil stigebil deleted the bug/kslivshendelse branch January 2, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants