-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lager fallback til manuell journalføringtask når det ikke finnes en aktiv brukerIdent i PDL #1192
The head ref may contain hidden characters: "NAV-23012/Lager-fallback-til-manuell-journalf\u00F8ringtask"
Lager fallback til manuell journalføringtask når det ikke finnes en aktiv brukerIdent i PDL #1192
Conversation
Code Coverage
|
src/main/kotlin/no/nav/familie/baks/mottak/task/JournalhendelseBarnetrygdRutingTask.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/no/nav/familie/baks/mottak/task/JournalhendelseBarnetrygdRutingTaskTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syns det ser bra ut! Veldig bra at dere skriver tester. La til noen kommentarer 😄
Code Coverage
|
Code Coverage
|
@@ -66,7 +66,18 @@ class PdlClient( | |||
fun hentPersonident( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hadde vært smooth med noen enhetstester på denne metoden 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enig, og fikset! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage
|
Quality Gate passedIssues Measures |
Code Coverage
|
Favro: https://favro.com/organization/98c34fb974ce445eac854de0/1844bbac3b6605eacc8f5543?card=NAV-23012
Fikser task https://familie-prosessering.intern.nav.no/service/familie-baks-mottak/task/61843650
Denne tasken har ikke fått noen aktive personidenter fra PDL på en aktørID, dermed feiler tasken. Vi endrer slik at man alltid oppretter en manuell journalføringstask når slike ting skjer.