Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lager fallback til manuell journalføringtask når det ikke finnes en aktiv brukerIdent i PDL #1192

Merged

Conversation

hanneolsen
Copy link
Contributor

Favro: https://favro.com/organization/98c34fb974ce445eac854de0/1844bbac3b6605eacc8f5543?card=NAV-23012

Fikser task https://familie-prosessering.intern.nav.no/service/familie-baks-mottak/task/61843650

Denne tasken har ikke fått noen aktive personidenter fra PDL på en aktørID, dermed feiler tasken. Vi endrer slik at man alltid oppretter en manuell journalføringstask når slike ting skjer.

@hanneolsen hanneolsen requested a review from a team as a code owner October 25, 2024 12:57
Copy link

Code Coverage

Overall Project 57.9%
Files changed 100% 🍏

File Coverage
JournalhendelseKontantstøtteRutingTask.kt 81.1% 🍏
JournalhendelseBarnetrygdRutingTask.kt 76.95% 🍏

Copy link
Contributor

@thoalm thoalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syns det ser bra ut! Veldig bra at dere skriver tester. La til noen kommentarer 😄

Copy link

Code Coverage

Overall Project 57.76% -0.04%
Files changed 88.31% 🍏

File Coverage
JournalhendelseKontantstøtteRutingTask.kt 81.1% 🍏
JournalhendelseBarnetrygdRutingTask.kt 76.95% 🍏
PdlClient.kt 76.19% -0.78% 🍏

Copy link

Code Coverage

Overall Project 57.76% -0.04%
Files changed 88.31% 🍏

File Coverage
JournalhendelseKontantstøtteRutingTask.kt 81.1% 🍏
JournalhendelseBarnetrygdRutingTask.kt 76.95% 🍏
PdlClient.kt 76.19% -0.78% 🍏

@@ -66,7 +66,18 @@ class PdlClient(
fun hentPersonident(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadde vært smooth med noen enhetstester på denne metoden 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enig, og fikset! 😄

Copy link
Contributor

@stigebil stigebil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 57.8%
Files changed 100% 🍏

File Coverage
JournalhendelseKontantstøtteRutingTask.kt 81.1% 🍏
PdlClient.kt 76.98% 🍏
JournalhendelseBarnetrygdRutingTask.kt 76.95% 🍏

Copy link

sonarcloud bot commented Nov 6, 2024

Copy link

github-actions bot commented Nov 6, 2024

Code Coverage

Overall Project 57.26%
Files changed 100% 🍏

File Coverage
PdlClient.kt 76.98% 🍏
JournalhendelseBarnetrygdRutingTask.kt 76.95% 🍏
JournalhendelseKontantstøtteRutingTask.kt 62.8% 🍏

@hanneolsen hanneolsen added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 3c9f081 Nov 7, 2024
4 checks passed
@hanneolsen hanneolsen deleted the NAV-23012/Lager-fallback-til-manuell-journalføringtask branch November 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants