Nav 23517 validere saksbehandler opp mot enhet #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,8 +31,11 @@ class OppdaterAnsvarligSaksbehandlerTask( | |||
| val oppgave = oppgaveService.finnOppgaveForBehandlingUtenOppgaveType(behandlingId) | |||
| val prioritet = oppgavePrioritetService.utledOppgaveprioritet(behandlingId, oppgave) | |||
|
|
|||
| if (oppgave.tilordnetRessurs != behandling.ansvarligSaksbehandler || oppgave.prioritet != prioritet) { | |||
| try { | |||
There was a problem hiding this comment.
if-sjekken kan beholdes rundt hele greia - for vi trenger ikke å "oppdatere" oppgaven dersom det ikke er noen endringer - det skaper litt støy i oppgaven (får generert en ekstra rad med tekst hver gang den oppdateres)
charliemidtlyng
approved these changes
Dec 16, 2024
…kke er noe endring
amiraliw
force-pushed
the
NAV-23517-Validere-saksbehandler-opp-mot-enhet
branch
from
46731c8 to
8820381
Compare
ma10s
reviewed
Dec 17, 2024
| oppgaveService.patchOppgave(oppgave.copy(tilordnetRessurs = behandling.ansvarligSaksbehandler, prioritet = prioritet)) | ||
| } catch (e: Exception) { | ||
| oppgaveService.patchOppgave(oppgave.copy(prioritet = prioritet)) | ||
| log.info("Kunne ikke oppdatere tilordnetRessurs. Mulig årsak kan være at eneht på oppgaven og enhet hos saksbehandleren er IKKE det samme!") |
There was a problem hiding this comment.
Logge som warning?
Typo : eneht -> enhet
ma10s
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erstattet if-statement med en try-catch slik at oppgaven oppdateres uten feil selv om enhet på oppgaven og enhet på den nye saksbehandleren ikke samsvarer.