Fix invalid partner #242
Merged
Fix invalid partner #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geir-waagboe
commented
Aug 29, 2023
| @@ -59,7 +59,7 @@ class PartnerinfoClient( | |||
| COUNT_CALL_PARTNERINFO_MULTIPLE_RESPONSE.increment() | |||
| } | |||
|
|
|||
| return response.maxByOrNull { it.partnerId } | |||
| return response.minByOrNull { it.partnerId } | |||
There was a problem hiding this comment.
Ser ut til at den del problemer blir forårsaket av duplikate partnerId'er i oppslag vi syfopartnerinfo. Kan se ut som det dukker opp nye feilaktige partnerId'er sporadisk, og hvis disse er større enn den opprinnelige vi hadde er det bedre å bruke minBy i stedet for maxBy.
There was a problem hiding this comment.
Har grav litt mer i dette, og tror ikke mønsteret er så klart - så reverterer denne endringen før merge.
andersrognstad
approved these changes
Aug 29, 2023
JMLindseth
approved these changes
Aug 29, 2023
eirikdahlen
approved these changes
Aug 29, 2023
geir-waagboe
force-pushed
the
fix-invalid-partner-id
branch
from
8510314 to
62d2469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dette håndterer den første problemet rapporert av e-mottak.