-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gjer at vi tåler nye Hendelse-kategoriar #1819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prodsette: Sortering på Utgått varsel-dato
Legg til rette for å ta i mot nye kategoriar
ingfo
force-pushed
the
juster-tester-utgatt-varsel
branch
2 times, most recently
from
December 18, 2024 12:39
7ca03db
to
7cd6e77
Compare
… på filterhendelse
ingfo
force-pushed
the
juster-tester-utgatt-varsel
branch
from
December 18, 2024 12:45
7cd6e77
to
7ff7152
Compare
ikkje eldste uavhengig av kategori
JulieHillRoa
approved these changes
Dec 18, 2024
ingfo
changed the title
Juster tester utgatt varsel
Gjer at vi tåler nye Hendelse-kategoriar
Dec 19, 2024
og gjort hentEldste meir generell/gjenbrukbar Co-authored-by: Sondre Larsen Ovrid <sondre.larsen.ovrid@nav.no>
Co-authored-by: Sondre Larsen Ovrid <sondre.larsen.ovrid@nav.no>
slovrid
approved these changes
Dec 19, 2024
Quality Gate passedIssues Measures |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Verdi:
Problemstilling:
Koden er enn så lenge ikkje skriven for å tåle ulike hendelseskategoriar. Det kan hende testar knekk, og at eksisterande filter ikkje oppfører seg som venta.
Konklusjon etter utforsking:
hentEldste bryr seg ikkje om typen hendelse, den ser kun på dato og personident.
Oppdatering av eldste hendelse i opensearch vil bli feil dersom:
Vi oppdaterer ikkje opensearch med andre hendelsestypar enn Utgått varsel.
Løysing
Trello ticket number and link
https://trello.com/c/2Jf2O0Pk/857-gjer-at-vi-kan-ta-i-mot-udelt-samtalereferat-utan-at-utg%C3%A5tte-varsel-f%C3%A5r-feil
Type of change
Checklist before requesting a review