Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedicating kind type and adding its methods. #144

Closed
wants to merge 2 commits into from

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 9, 2024

I've made a new type Kind which is equal to uint16. it supports fixed numbers of all Kinds. but the int type is basically int32 and int64 based on the target device (as far as I know), which can hold bigger numbers and it's unnecessary. Also, some methods were added for getting the range of a kind which can help in the relay or maybe client Implementations.

Example: https://github.com/dezh-tech/immortal/blob/main/types/kind.go

@fiatjaf
Copy link
Collaborator

fiatjaf commented Sep 9, 2024

I don't like the extra cognitive load for very little gain, but maybe, let me think about it.

@kehiy
Copy link
Contributor Author

kehiy commented Sep 9, 2024

@fiatjaf That's OK. We can remove the type itself, but keep the methods!

@kehiy
Copy link
Contributor Author

kehiy commented Sep 11, 2024

do you think we should close this one? i'm trying to make another pr but I made this one on the master branch. so, it seems i'm limited now.

@kehiy
Copy link
Contributor Author

kehiy commented Sep 11, 2024

I close this and open it on another branch.

@kehiy kehiy closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants