Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security(event, checksig): validate correction of id. #146

Closed
wants to merge 1 commit into from

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 11, 2024

with removing new conditions on checksig, you can see new invalid test case will pass the test!

@kehiy kehiy changed the title security(event, checksig): validate correction of id security(event, checksig): validate correction of id. Sep 11, 2024
@kehiy kehiy closed this Sep 13, 2024
@kehiy kehiy deleted the hotfix/id branch September 13, 2024 19:32
@fiatjaf
Copy link
Collaborator

fiatjaf commented Sep 14, 2024

My answers to this on DM:

fiatjaf, [9/11/24 7:12 PM]
the signature is being checked against the correct id already

fiatjaf, [9/11/24 7:12 PM]
what isn't being checked is if the id in the event is the correct id

fiatjaf, [9/11/24 7:12 PM]
but that is checked in other parts of the code

fiatjaf, [9/11/24 7:12 PM]
I didn't want to duplicate the checks

@kehiy
Copy link
Contributor Author

kehiy commented Sep 14, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants