handle connectionstrings with authority #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If everybody is using the |
|
Am I stupid? I had never seen this PR here ever. |
While that does sound practical, I am not a fan of doing things wrong knowingly, just because the majority does it that way. These implementations are in the wrong and should update. However I am also not going to die on this hill. |
|
Is this PR still valid? I don't know anything about NWC, so please decide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny change in the NIP-47 utilities to handle the very real case of a NWC provider using connection URIs that don't comply with the spec and instead use "schema://pubkey". This change ensure compatibility with both.
Examples of NWC providers that use Authority are: