Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement PR#55, fix for remote ontology pull with gzipped submissions #73

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Feb 2, 2024

re-implement PR#55 introduced by @syphax-bouazzouni to fix remote ontology pull with gzipped submissions

BioPortal fork was refactored after PR#55 was made which made merging original PR a bit tricky.

…ions

NCBO code was refactored after PR#55 was made which made merging original pr a bit tricky.
This change incorporates changes introduced in PR#55
@alexskr alexskr changed the title re-implement PR#55, fix for remote ontology pull with gzipped submiss… re-implement PR#55, fix for remote ontology pull with gzipped submissions Feb 2, 2024
@alexskr alexskr requested a review from mdorf February 2, 2024 21:16
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8e3d46f) 54.64% compared to head (c1dbd8b) 54.57%.

Files Patch % Lines
lib/ncbo_cron/ontology_helper.rb 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
- Coverage    54.64%   54.57%   -0.07%     
===========================================
  Files           16       16              
  Lines         1239     1235       -4     
===========================================
- Hits           677      674       -3     
+ Misses         562      561       -1     
Flag Coverage Δ
unittests 54.57% <57.14%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr marked this pull request as draft February 2, 2024 21:49
@alexskr alexskr marked this pull request as ready for review February 2, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants