Upgrade hsql to 2.7.1 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-gson-2.8.9' into dependancy-updates
…wder/com.google.code.gson-gson-2.8.9' into dependancy-updates
…or-hpc/com.jcraft-jsch-0.1.54' into dependancy-updates
|
Next time, can you please use the issue number in the branch name? It adds some nice metadata so we can track which issue this was associated with. Thank you! |
navarroc
requested changes
Sep 13, 2024
pom.xml
Outdated
| @@ -11,7 +11,7 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <hibernate.jpa.version>1.0.0.Final</hibernate.jpa.version> | |||
| <hibernate.version>4.3.5.Final</hibernate.version> | |||
| <hsql.version>2.3.2</hsql.version> | |||
| <hsql.version>2.7.1</hsql.version> | |||
There was a problem hiding this comment.
Can we just go to the latest (2.7.3)?
There was a problem hiding this comment.
Sure, I just updated it
navarroc
reviewed
Sep 20, 2024
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ### Changed | |||
| - Kubernetes executor prints exception [#23](https://github.com/ncsa/datawolf/issues/23) | |||
| - Clean dependency updates [#27](https://github.com/ncsa/datawolf/issues/27) | |||
There was a problem hiding this comment.
Can you change this entry to something like "hsqldb to 2.7.3" so it's more descriptive of what was done? Thanks! After that, I think it's ready to merge.
navarroc
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested creating tools and execution in the updated image. All work fine.