Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Git and Diagnostics Highlights in barbar.nvim #29

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

okm321
Copy link
Contributor

@okm321 okm321 commented Sep 1, 2024

First of all, thank you for providing this theme for nvim!

While using barbar, I noticed that the background color for the Git status icons and diagnostic icons sometimes appears by default, which can reduce visibility. To improve this, I checked the official barbar documentation and added the necessary changes to highlights.lua. I hope this enhancement will be helpful to others using both this theme and barbar!

before after
CleanShot 2024-09-01 at 22 13 03 CleanShot 2024-09-01 at 22 09 26

related issue: #28

Copy link
Owner

@neanias neanias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there! Thanks for the PR. Would you change the ADDED colours to use palette.green rather than aqua, please? That way, it will match the standard colours for added/changed/deleted. Thanks!

@okm321
Copy link
Contributor Author

okm321 commented Sep 3, 2024

@neanias
Thanks for catching that! I've updated the colours to use palette.green as requested!
d614daf

@okm321 okm321 requested a review from neanias September 3, 2024 12:59
@neanias neanias merged commit 9b13671 into neanias:main Sep 3, 2024
2 checks passed
@neanias neanias linked an issue Sep 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlighting Issue with Git and Diagnostics When Using barbar.nvim
2 participants