Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated nft marketplace logic #1773

Closed
wants to merge 3 commits into from
Closed

Updated nft marketplace logic #1773

wants to merge 3 commits into from

Conversation

garikbesson
Copy link
Collaborator

We leave nft_on_approve callback for some internal marketplace logic and create a new list_nft_for_sale method. In this method, we check if the signer is NFT owner and if the marketplace contract is approved on NFT.

@gagdiez
Copy link
Collaborator

gagdiez commented Apr 26, 2024

@garikbesson asked me to close this in favor of #1880

@gagdiez gagdiez closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bucanero bucanero bucanero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevRel
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garikbesson @gagdiez @bucanero