Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies in Cargo.toml files #1263

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

virajbhartiya
Copy link

Closes #1257

Removed the individual export for cargo-near-build to use the default exported dependency

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (22f3500) to head (9c10e9c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   80.16%   80.15%   -0.02%     
==========================================
  Files         102      102              
  Lines       14598    14598              
==========================================
- Hits        11703    11701       -2     
- Misses       2895     2897       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@virajbhartiya
Copy link
Author

virajbhartiya commented Nov 22, 2024

@dj8yfo can you please suggest me a way to include build_script in the imports

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 22, 2024

@virajbhartiya please revert the change for build-script. This must be lines for factory-contract.
Importing it directly for build-scripts with additional features is ok, and is somewhat distinct purpose than routinely compiling contracts for tests.
Also these weren't referenced in the issue

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 23, 2024

@virajbhartiya together with reverting examples/factory-contract you
removed lines with import use near_workspaces::cargo_near_build;
in tests of examples/fungible-token, examples/lockable-fungible-token, examples/non-fungible-token, did you?
Add these lines, and 6 test jobs should start passing

@dj8yfo dj8yfo marked this pull request as draft November 25, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove direct dependency on cargo-near-build in some of examples
2 participants