Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate log4j-jpl to JUnit5 #3

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

ninetteadhikari
Copy link
Member

@ninetteadhikari ninetteadhikari commented Sep 27, 2024

Introduction

We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in log4j-jpl to JUnit5.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

Signed-off-by: Ninette Adhikari <ninette.adhikari@gmail.com>
@ninetteadhikari ninetteadhikari marked this pull request as ready for review September 27, 2024 11:56
@ninetteadhikari ninetteadhikari changed the title refactor: Migrate log4j-jpl to junit5 refactor: Migrate log4j-jpl to JUnit5 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants